[QAT Lora 5/N] Fixes for loading/saving compression checkpoint #3341
+130
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF PT
ljaljushkin
force-pushed
the
nl/fq_lora_pr_ckpt
branch
from
555f16e to
a06b2e9
Compare
ljaljushkin
force-pushed
the
nl/fq_lora_pr_ckpt
branch
from
a06b2e9 to
69df6d8
Compare
github-actions
bot
removed
NNCF Common
ljaljushkin
force-pushed
the
nl/fq_lora_pr_ckpt
branch
from
b5e9edb to
a15ca14
Compare
daniil-lyakhov
approved these changes
Mar 18, 2025
AlexanderDokuchaev
requested changes
Mar 19, 2025
AlexanderDokuchaev
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added test for loading/saving compression checkpoint. Fixed revealed errors with different device and invalid lora rank.
Reason for changes
Compression module and the corresponding layer may have a different device in multi-device setup (e.g. when HF model was loaded with device_map='auto'). Need to align devices.
Related tickets
154907
Tests